Fix bug of connection event of gamepad at startup #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit removes the floating point equality comparison by modifying the filter function. Now filter function outputs
Option<f32>
instead off32
and output isNone
when no change is required.Second commit fixes the bug which makes it impossible to detect already connected gamepads at game startup. If you plug the gamepad first and then launches the game, connection event wouldn't occur. Removal of this code causes this bug.
To detect already connected gamepads' connection events at startup, a system must query for events at
POST_STARTUP
stage becausebevy_gilrs
generates raw events atPRE_STARTUP
stage andbevy_input
generates filtered events atSTARTUP
stage (it must execute afterbevy_gilrs
system).