-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to rodio 0.12 #638
Conversation
The way I've seen to handle |
The best way to handle |
It seems rodio 0.12 also fixes the issue where playing an mp3 file would sometimes panic in debug mode. As for the |
I think we have reason enough to wait for thread local here: #310 (comment) I'll try to bang that out today |
Just put out a pr for thread local resources #671 |
Just merged thread local resources. Lets try to use that here instead of mem::forget (see the bevy_gilrs code for examples) |
Closed by #692 |
This is actually same as #310 but i deleted the fork sometime ago so i can't add new commits. Fixes #307. We need to find a way to handle the OutputStream (it is not Send + Sync) now i just mem::forget it but we need a better way.