Fix Added behaviour with QueryOne get #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisBoutillier
commented
Sep 21, 2020
crates/bevy_ecs/src/system/query.rs
Outdated
Comment on lines
57
to
68
| self.world | ||
| .get_ref_at_location_unchecked(location) | ||
| .map_err(QueryError::ComponentError) | ||
| if Q::Fetch::get( | ||
| &self.world.archetypes[location.archetype as usize], | ||
| location.index, | ||
| ) | ||
| .map_or(true, |f| f.should_skip()) | ||
| { | ||
| Err(QueryError::ComponentError(ComponentError::NoSuchEntity)) | ||
| } else { | ||
| self.world | ||
| .get_ref_at_location_unchecked(location) | ||
| .map_err(QueryError::ComponentError) | ||
| } |
There was a problem hiding this comment.
I am clearly not confident on this part of PR and would gladly have a thorough review here.
There was a problem hiding this comment.
Hmm this has significant performance implicantions because we are now doing a "full lookup" of every component storage in the query. I'm not sure thats worth the tradeoff when we can use "Query One" when this behavior is required.
I'm down to merge the "query one" part of this PR now, but this change will require some serious thought / im pretty sure its not worth it.
There was a problem hiding this comment.
Ok, I see and will update the PR to only include the query_one part.
karroffel
added
C-Bug
Query unchanged as impacts performances. Added tests in bevy_ecs/hecs
BorisBoutillier
changed the title
cart
approved these changes
Oct 5, 2020
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Query unchanged as impacts performances. Added tests in bevy_ecs/hecs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #541