-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix line material shader #5348
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superdump
approved these changes
Jul 17, 2022
superdump
added
C-Bug
An unexpected or incorrect behavior
A-Rendering
Drawing game state to the screen
labels
Jul 17, 2022
mockersf
approved these changes
Jul 17, 2022
this examples was added in #5319 after the update to wgpu 0.13 |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
I don't think a review from @IceSentry is necessary to wait for as the PR is only syntactical changes in WGSL, not functional changes in what the code does. |
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2022
# Objective - The line shader missed the wgpu 0.13 update (#5168) and does not work in it's current state ## Solution - update the shader
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix line material shader
[Merged by Bors] - Fix line material shader
Jul 17, 2022
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state ## Solution - update the shader
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state ## Solution - update the shader
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - The line shader missed the wgpu 0.13 update (bevyengine#5168) and does not work in it's current state ## Solution - update the shader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
C-Examples
An addition or correction to our examples
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution