-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add TextureAtlas stress test based on many_sprites and sprite_sheet examples #5087
Closed
james-j-obrien
wants to merge
8
commits into
bevyengine:main
from
james-j-obrien:animated-sprite-stress-test
Closed
[Merged by Bors] - Add TextureAtlas stress test based on many_sprites and sprite_sheet examples #5087
james-j-obrien
wants to merge
8
commits into
bevyengine:main
from
james-j-obrien:animated-sprite-stress-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
Drawing game state to the screen
C-Performance
A change motivated by improving speed, memory usage or compile times
A-Animation
Make things move and change over time
C-Examples
An addition or correction to our examples
labels
Jun 24, 2022
@ManevilleF, here's a nice little stress test for the changes in #5072 :) |
mockersf
requested changes
Jun 24, 2022
ManevilleF
approved these changes
Jul 2, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Jul 2, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 4, 2022
…xamples (#5087) # Objective Intended to close #5073 ## Solution Adds a stress test that use TextureAtlas based on the existing many_sprites test using the animated sprite implementation from the sprite_sheet example. In order to satisfy the goals described in #5073 the animations are all slightly offset. Of note is that the original stress test was designed to test fullstrum culling. I kept this test similar as to facilitate easy comparisons between the use of TextureAtlas and without.
bors
bot
changed the title
Add TextureAtlas stress test based on many_sprites and sprite_sheet examples
[Merged by Bors] - Add TextureAtlas stress test based on many_sprites and sprite_sheet examples
Jul 4, 2022
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
…xamples (bevyengine#5087) # Objective Intended to close bevyengine#5073 ## Solution Adds a stress test that use TextureAtlas based on the existing many_sprites test using the animated sprite implementation from the sprite_sheet example. In order to satisfy the goals described in bevyengine#5073 the animations are all slightly offset. Of note is that the original stress test was designed to test fullstrum culling. I kept this test similar as to facilitate easy comparisons between the use of TextureAtlas and without.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…xamples (bevyengine#5087) # Objective Intended to close bevyengine#5073 ## Solution Adds a stress test that use TextureAtlas based on the existing many_sprites test using the animated sprite implementation from the sprite_sheet example. In order to satisfy the goals described in bevyengine#5073 the animations are all slightly offset. Of note is that the original stress test was designed to test fullstrum culling. I kept this test similar as to facilitate easy comparisons between the use of TextureAtlas and without.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…xamples (bevyengine#5087) # Objective Intended to close bevyengine#5073 ## Solution Adds a stress test that use TextureAtlas based on the existing many_sprites test using the animated sprite implementation from the sprite_sheet example. In order to satisfy the goals described in bevyengine#5073 the animations are all slightly offset. Of note is that the original stress test was designed to test fullstrum culling. I kept this test similar as to facilitate easy comparisons between the use of TextureAtlas and without.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Animation
Make things move and change over time
A-Rendering
Drawing game state to the screen
C-Examples
An addition or correction to our examples
C-Performance
A change motivated by improving speed, memory usage or compile times
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Intended to close #5073
Solution
Adds a stress test that use TextureAtlas based on the existing many_sprites test using the animated sprite implementation from the sprite_sheet example.
In order to satisfy the goals described in #5073 the animations are all slightly offset.
Of note is that the original stress test was designed to test fullstrum culling. I kept this test similar as to facilitate easy comparisons between the use of TextureAtlas and without.