fix font atlas overflow #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
added
A-Assets
cart
reviewed
Sep 15, 2020
| @@ -55,7 +57,13 @@ impl FontAtlasSet { | |||
| let font_atlas = self | |||
There was a problem hiding this comment.
nit: lets rename this font_atlases now that its a vec
| if let Some(outlined_glyph) = scaled_font.outline_glyph(glyph.clone()) { | ||
| let glyph_texture = Font::get_outlined_glyph_texture(outlined_glyph); | ||
| font_atlas.add_char(textures, texture_atlases, character, &glyph_texture); | ||
| let add_char_to_fontatlas = |atlas: &mut FontAtlas| -> bool { |
There was a problem hiding this comment.
nit: as long as it is, naming conventions dictate that this should be add_char_to_font_atlas :)
There was a problem hiding this comment.
agreed - although I hate putting it into a Fn ... but clippy complained :-(
There was a problem hiding this comment.
bawhaha yeah sometimes clippy is overly opinionated imo.
| character, | ||
| &glyph_texture, | ||
| ) { | ||
| panic!("could not add character to newly created fontatlas"); |
There was a problem hiding this comment.
nit: lets use type name casing here: FontAtlas
|
Awesome. This is good to go. Thanks again! |
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
manage font_atlas overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue of overflowing (and panicing) font_atlasses.