[Merged by Bors] - Fix crash when using Duration::MAX #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jun 2, 2022
|
Do you mean add a comment near the if statement? |
|
Ah my bad. No, I meant as a comment on the variants in UpdateMode. |
Signed-off-by: Alex Saveau <[email protected]>
|
Gotya, done. |
james7132
approved these changes
Jun 2, 2022
james7132
added
the
S-Ready-For-Final-Review
| @@ -68,7 +68,11 @@ pub enum UpdateMode { | |||
| /// Once the app has executed all bevy systems and reaches the end of the event loop, there is | |||
| /// no way to force the app to wake and update again, unless a `winit` event (such as user | |||
| /// input, or the window being resized) is received or the time limit is reached. | |||
| Reactive { max_wait: Duration }, | |||
| Reactive { | |||
| /// The maximum time to wait before the event loop runs again. Note that if the duration is | |||
There was a problem hiding this comment.
These should be line split, and the advice should be more precise. What do we need to set the value to in order to get an indefinite wait?
In many ways, this is actually a feature, so we should demonstrate how to use it.
There was a problem hiding this comment.
Well the problem is that it's platform dependent. Some platforms store Instants as u32s, others store them as u64s so the answer is "dunno, you figure it out." :) That said, using Duration::MAX is effectively the same as waiting for ever so I made a note of that.
Signed-off-by: Alex Saveau <[email protected]>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
# Objective If you set the `ReactiveLowPower` max wait to `Duration::MAX`, stuff panics. Fix that. ## Solution Wait forever if addition failed.
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective If you set the `ReactiveLowPower` max wait to `Duration::MAX`, stuff panics. Fix that. ## Solution Wait forever if addition failed.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective If you set the `ReactiveLowPower` max wait to `Duration::MAX`, stuff panics. Fix that. ## Solution Wait forever if addition failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
If you set the
ReactiveLowPowermax wait toDuration::MAX, stuff panics. Fix that.Solution
Wait forever if addition failed.