Update camera_system to fix issue with late camera addition. #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
C-Bug
cart
requested changes
Sep 14, 2020
|
I can't use the get() because then I ends up in "bevy_render::camera::camera::Camera already borrowed uniquely" |
cart
approved these changes
Oct 5, 2020
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #476.
Not sure if this is the best implementation for the fix.
As there is no AddedMut I was not able to do a standalone second query for added camera and their projection.
This version is solving the issue, I have checked with the modified sprite.rs/3d_scene.rs and my personal code.
Added an entry in the CHANGELOG