[Merged by Bors] - Add QueryState::get_single_unchecked_manual and its family #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix formatting
Shatur
changed the title
Shatur
changed the title
alice-i-cecile
added
A-ECS
|
This is ready to merge once the lifetimes are fixed. |
|
Going to get one final review from the lifetime crew to verify. |
BoxyUwU
approved these changes
May 26, 2022
TheRawMeatball
approved these changes
May 27, 2022
james7132
added
the
S-Ready-For-Final-Review
| @@ -258,7 +258,7 @@ struct QueryIterationCursor<'w, 's, Q: WorldQuery, QF: Fetch<'w, State = Q::Stat | |||
| filter: QueryFetch<'w, F>, | |||
| current_len: usize, | |||
| current_index: usize, | |||
| phantom: PhantomData<&'w Q>, | |||
| phantom: PhantomData<(&'w (), Q)>, | |||
There was a problem hiding this comment.
This change shouldn't be needed; what happens if you remove it?
There was a problem hiding this comment.
@alice-i-cecile Compilation error that I mentioned in Discord. @BoxyUwU suggested this fix for it.
There was a problem hiding this comment.
for future context &'w Q requires Q: 'w to hold which is unnecessary, this change makes that not required
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
# Objective - Rebase of #3159. - Fixes #3156 - add #[inline] to single related functions so that they matches with other function defs ## Solution * added functions to QueryState * get_single_unchecked_manual * get_single_unchecked * get_single * get_single_mut * single * single_mut * make Query::get_single use QueryState::get_single_unchecked_manual * added #[inline] --- ## Changelog ### Added Functions `QueryState::single`, `QueryState::get_single`, `QueryState::single_mut`, `QueryState::get_single_mut`, `QueryState::get_single_unchecked`, `QueryState::get_single_unchecked_manual`. ### Changed `QuerySingleError` is now in the `state` module. ## Migration Guide Change `query::QuerySingleError` to `state::QuerySingleError` Co-authored-by: 2ne1ugly <[email protected]> Co-authored-by: 2ne1ugly <[email protected]>
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
…e#4841) # Objective - Rebase of bevyengine#3159. - Fixes bevyengine#3156 - add #[inline] to single related functions so that they matches with other function defs ## Solution * added functions to QueryState * get_single_unchecked_manual * get_single_unchecked * get_single * get_single_mut * single * single_mut * make Query::get_single use QueryState::get_single_unchecked_manual * added #[inline] --- ## Changelog ### Added Functions `QueryState::single`, `QueryState::get_single`, `QueryState::single_mut`, `QueryState::get_single_mut`, `QueryState::get_single_unchecked`, `QueryState::get_single_unchecked_manual`. ### Changed `QuerySingleError` is now in the `state` module. ## Migration Guide Change `query::QuerySingleError` to `state::QuerySingleError` Co-authored-by: 2ne1ugly <[email protected]> Co-authored-by: 2ne1ugly <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…e#4841) # Objective - Rebase of bevyengine#3159. - Fixes bevyengine#3156 - add #[inline] to single related functions so that they matches with other function defs ## Solution * added functions to QueryState * get_single_unchecked_manual * get_single_unchecked * get_single * get_single_mut * single * single_mut * make Query::get_single use QueryState::get_single_unchecked_manual * added #[inline] --- ## Changelog ### Added Functions `QueryState::single`, `QueryState::get_single`, `QueryState::single_mut`, `QueryState::get_single_mut`, `QueryState::get_single_unchecked`, `QueryState::get_single_unchecked_manual`. ### Changed `QuerySingleError` is now in the `state` module. ## Migration Guide Change `query::QuerySingleError` to `state::QuerySingleError` Co-authored-by: 2ne1ugly <[email protected]> Co-authored-by: 2ne1ugly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
QueryState::get_single_unchecked_manualand its family #3159.Solution
Changelog
Added
Functions
QueryState::single,QueryState::get_single,QueryState::single_mut,QueryState::get_single_mut,QueryState::get_single_unchecked,QueryState::get_single_unchecked_manual.Changed
QuerySingleErroris now in thestatemodule.Migration Guide
Change
query::QuerySingleErrortostate::QuerySingleError