Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix type parameter name conflicts of derive(Bundle) #4636

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix type parameter name conflicts of derive(Bundle) #4636

wants to merge 1 commit into from

Conversation

infmagic2047
Copy link
Contributor

Objective

This code currently fails to compile with error the name `T` is already used for a generic parameter in this item's generic parameters, because T is also used in code generated by derive(Bundle).

#[derive(Bundle)]
struct MyBundle<T: Component> {
    component: T,
}

Solution

Add double underscores to type parameter names in derive(Bundle).

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label May 1, 2022
@BoxyUwU BoxyUwU added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels May 1, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 2, 2022
@infmagic2047
Fix type parameter name conflicts of derive(Bundle) (#4636)
2c14582 
# Objective

This code currently fails to compile with error ``the name `T` is already used for a generic parameter in this item's generic parameters``, because `T` is also used in code generated by `derive(Bundle)`.

```rust
#[derive(Bundle)]
struct MyBundle<T: Component> {
    component: T,
}
```

## Solution

Add double underscores to type parameter names in `derive(Bundle)`.
@bors
Copy link
Contributor

bors bot commented May 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix type parameter name conflicts of derive(Bundle) [Merged by Bors] - Fix type parameter name conflicts of derive(Bundle) May 2, 2022
@bors bors bot closed this May 2, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@infmagic2047 @exjam
Fix type parameter name conflicts of derive(Bundle) (bevyengine#4636)
a7bea59 
# Objective

This code currently fails to compile with error ``the name `T` is already used for a generic parameter in this item's generic parameters``, because `T` is also used in code generated by `derive(Bundle)`.

```rust
#[derive(Bundle)]
struct MyBundle<T: Component> {
    component: T,
}
```

## Solution

Add double underscores to type parameter names in `derive(Bundle)`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@infmagic2047 @ItsDoot
Fix type parameter name conflicts of derive(Bundle) (bevyengine#4636)
5f3818e 
# Objective

This code currently fails to compile with error ``the name `T` is already used for a generic parameter in this item's generic parameters``, because `T` is also used in code generated by `derive(Bundle)`.

```rust
#[derive(Bundle)]
struct MyBundle<T: Component> {
    component: T,
}
```

## Solution

Add double underscores to type parameter names in `derive(Bundle)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

@BoxyUwU BoxyUwU BoxyUwU approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@infmagic2047 @alice-i-cecile @BoxyUwU @MrGVSV