Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove nonexistent WgpuResourceDiagnosticsPlugin #4541

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove nonexistent WgpuResourceDiagnosticsPlugin #4541

wants to merge 1 commit into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Apr 19, 2022

Objective

Uncommenting the following results in a compile error:

bevy/examples/diagnostics/log_diagnostics.rs

Lines 14 to 15 in 7557f4d

// Uncomment this to add some render resource diagnostics:
// .add_plugin(bevy::wgpu::diagnostic::WgpuResourceDiagnosticsPlugin::default())

Solution

Remove the commented line.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 19, 2022
@mockersf mockersf added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Apr 19, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 19, 2022
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 20, 2022
@MrGVSV
Remove nonexistent WgpuResourceDiagnosticsPlugin (#4541)
80c6bab 
# Objective

Uncommenting the following results in a compile error: https://github.com/bevyengine/bevy/blob/7557f4db83b8e9d3049f242bd4b58f8546bb1510/examples/diagnostics/log_diagnostics.rs#L14-L15

## Solution

Remove the commented line.
@bors
Copy link
Contributor

bors bot commented Apr 20, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove nonexistent WgpuResourceDiagnosticsPlugin [Merged by Bors] - Remove nonexistent WgpuResourceDiagnosticsPlugin Apr 20, 2022
@bors bors bot closed this Apr 20, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@MrGVSV @exjam
Remove nonexistent WgpuResourceDiagnosticsPlugin (bevyengine#4541)
1ec9e48 
# Objective

Uncommenting the following results in a compile error: https://github.com/bevyengine/bevy/blob/7557f4db83b8e9d3049f242bd4b58f8546bb1510/examples/diagnostics/log_diagnostics.rs#L14-L15

## Solution

Remove the commented line.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@MrGVSV @ItsDoot
Remove nonexistent WgpuResourceDiagnosticsPlugin (bevyengine#4541)
60c00c6 
# Objective

Uncommenting the following results in a compile error: https://github.com/bevyengine/bevy/blob/7557f4db83b8e9d3049f242bd4b58f8546bb1510/examples/diagnostics/log_diagnostics.rs#L14-L15

## Solution

Remove the commented line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGVSV @mockersf @alice-i-cecile