[Merged by Bors] - increase the maximum number of point lights with shadows to the max supported by the device #4435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Rendering
superdump
requested changes
Apr 6, 2022
superdump
reviewed
Apr 7, 2022
superdump
approved these changes
Apr 7, 2022
|
Approved, but maybe update the PR title? :) |
mockersf
changed the title
IceSentry
reviewed
Apr 7, 2022
| .iter() | ||
| .filter(|light| light.1.shadows_enabled) | ||
| .count() | ||
| .min((render_device.limits().max_texture_array_layers / 6) as usize); |
There was a problem hiding this comment.
What's the 6 here and on line 662? I'm not sure what it's supposed to mean
There was a problem hiding this comment.
True. It is a ‘magic number’ I guess though it’s already been used elsewhere so I’d fix it in a separate PR. Point lights use cubemaps for shadow mapping. Cubemaps are array textures with 6 layers per cubemap, one for each cube face. That’s where the 6 comes from.
There was a problem hiding this comment.
Yep, doesn't need to be fixed here, it was just for my own learning purposes, thanks!
IceSentry
approved these changes
Apr 7, 2022
cart
approved these changes
Apr 7, 2022
Co-authored-by: Robert Swain <[email protected]>
mockersf
force-pushed
the
raise-pointlight-with-shadow-limit
branch
from
9accd9a to
d513335
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
…upported by the device (#4435) # Objective - Being limited to 10 pointlights with shadow is very limiting ## Solution - Raise the limit
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…upported by the device (bevyengine#4435) # Objective - Being limited to 10 pointlights with shadow is very limiting ## Solution - Raise the limit
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…upported by the device (bevyengine#4435) # Objective - Being limited to 10 pointlights with shadow is very limiting ## Solution - Raise the limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution