[Merged by Bors] - gltf-loader: disable backface culling if material is double-sided #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
added
C-Bug
mockersf
approved these changes
Mar 20, 2022
Can you please make and link and issue for this? |
alice-i-cecile
approved these changes
Mar 20, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Actually it looks like we do this already, so no need to do anything: https://github.com/bevyengine/bevy/blob/main/crates/bevy_pbr/src/render/pbr.wgsl#L505 |
superdump
approved these changes
Mar 20, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2022
) # Objective The [glTF spec](https://github.com/KhronosGroup/glTF/blob/8e798b02d254cea97659a333cfcb20875b62bdd4/specification/2.0/Specification.adoc#395-double-sided) the `doubleSided` has the following to say about the `doubleSided` boolean: > When this value is false, back-face culling is enabled, i.e., only front-facing triangles are rendered. > When this value is true, back-face culling is disabled and double sided lighting is enabled. The back-face MUST have its normals reversed before the lighting equation is evaluated. ## Solution Disable backface culling when `doubleSided: true`.
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…vyengine#4270) # Objective The [glTF spec](https://github.com/KhronosGroup/glTF/blob/8e798b02d254cea97659a333cfcb20875b62bdd4/specification/2.0/Specification.adoc#395-double-sided) the `doubleSided` has the following to say about the `doubleSided` boolean: > When this value is false, back-face culling is enabled, i.e., only front-facing triangles are rendered. > When this value is true, back-face culling is disabled and double sided lighting is enabled. The back-face MUST have its normals reversed before the lighting equation is evaluated. ## Solution Disable backface culling when `doubleSided: true`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…vyengine#4270) # Objective The [glTF spec](https://github.com/KhronosGroup/glTF/blob/8e798b02d254cea97659a333cfcb20875b62bdd4/specification/2.0/Specification.adoc#395-double-sided) the `doubleSided` has the following to say about the `doubleSided` boolean: > When this value is false, back-face culling is enabled, i.e., only front-facing triangles are rendered. > When this value is true, back-face culling is disabled and double sided lighting is enabled. The back-face MUST have its normals reversed before the lighting equation is evaluated. ## Solution Disable backface culling when `doubleSided: true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The glTF spec the
doubleSidedhas the following to say about thedoubleSidedboolean:Solution
Disable backface culling when
doubleSided: true.