-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix clicked UI nodes getting reset when hovering child nodes #4194
Closed
oceantume
wants to merge
3
commits into
bevyengine:main
from
oceantume:ui-nodes-child-hover-reset-fix
Closed
[Merged by Bors] - Fix clicked UI nodes getting reset when hovering child nodes #4194
oceantume
wants to merge
3
commits into
bevyengine:main
from
oceantume:ui-nodes-child-hover-reset-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oceantume
commented
Mar 12, 2022
alice-i-cecile
added
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Bug
An unexpected or incorrect behavior
and removed
S-Needs-Triage
This issue needs to be labelled
labels
Mar 12, 2022
alice-i-cecile
approved these changes
Mar 12, 2022
sixfold-origami
approved these changes
Apr 6, 2022
Looks great! Not much to say on a 2 line PR 😅 |
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Apr 6, 2022
IceSentry
approved these changes
Apr 7, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
# Objective Fixes #4193 ## Solution When resetting a node's `Interaction` to `None`, ignore any `Clicked` node because that should be handled by the mouse release check exclusively.
bors
bot
changed the title
Fix clicked UI nodes getting reset when hovering child nodes
[Merged by Bors] - Fix clicked UI nodes getting reset when hovering child nodes
Apr 7, 2022
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
…ine#4194) # Objective Fixes bevyengine#4193 ## Solution When resetting a node's `Interaction` to `None`, ignore any `Clicked` node because that should be handled by the mouse release check exclusively.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ine#4194) # Objective Fixes bevyengine#4193 ## Solution When resetting a node's `Interaction` to `None`, ignore any `Clicked` node because that should be handled by the mouse release check exclusively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Bug
An unexpected or incorrect behavior
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4193
Solution
When resetting a node's
Interaction
toNone
, ignore anyClicked
node because that should be handled by the mouse release check exclusively.