[Merged by Bors] - Move float_ord from bevy_core to bevy_utils #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
| @@ -41,12 +41,12 @@ impl Hash for FloatOrd { | |||
| fn hash<H: Hasher>(&self, state: &mut H) { | |||
| if self.0.is_nan() { | |||
| // Ensure all NaN representations hash to the same value | |||
| state.write(bytemuck::bytes_of(&f32::NAN)); | |||
| state.write(&f32::to_ne_bytes(f32::NAN)); | |||
There was a problem hiding this comment.
What's up with this change?
There was a problem hiding this comment.
bevy_utils doesn't use bytemuck (currently, at least), so rather than add a bytemuck dep I just wrote the equivalent code with std support.
If it's preferred, we could just add bytemuck to bevy_utils, but it is in fact equivalent either way.
(It might be plausible that the bytemuck reëxport moves from bevy_core to bevy_utils as well, but I'm unsure about that one and just wanted to move FloatOrd here.)
There was a problem hiding this comment.
Sounds good to me; I'm content not to pull in the dependency here.
|
One quick question. I like this change though; it's clearly the right organization and the rest lgtm. |
alice-i-cecile
approved these changes
Mar 12, 2022
james7132
approved these changes
Mar 13, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors try |
mockersf
approved these changes
Mar 14, 2022
|
@CAD97 can you rebase? |
|
Rebased. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
# Objective Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils. A step in addressing #2931 and splitting bevy_core into more specific locations. ## Solution Move FloatOrd into bevy_utils. Fix the compile errors. As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for `FloatOrd` previously).
bors
bot
changed the title
|
This should be labeled as a breaking change: those who import single items from Bevy instead of the prelude will have their builds broken. |
mockersf
added
the
M-Needs-Migration-Guide
|
@CAD97 can you add a quick migration guide to this? |
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils. A step in addressing bevyengine#2931 and splitting bevy_core into more specific locations. ## Solution Move FloatOrd into bevy_utils. Fix the compile errors. As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for `FloatOrd` previously).
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils. A step in addressing bevyengine#2931 and splitting bevy_core into more specific locations. ## Solution Move FloatOrd into bevy_utils. Fix the compile errors. As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for `FloatOrd` previously).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Reduce the catch-all grab-bag of functionality in bevy_core by moving FloatOrd to bevy_utils.
A step in addressing #2931 and splitting bevy_core into more specific locations.
Solution
Move FloatOrd into bevy_utils. Fix the compile errors.
As a result, bevy_core_pipeline, bevy_pbr, bevy_sprite, bevy_text, and bevy_ui no longer depend on bevy_core (they were only using it for
FloatOrdpreviously).Migration guide
Replace imports of
bevy::core::FloatOrdwithbevy::utils::FloatOrd.