[Merged by Bors] - Fix UI node Transform change detection #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-UI
alice-i-cecile
approved these changes
Mar 7, 2022
ghost
approved these changes
Mar 7, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
james7132
reviewed
Mar 7, 2022
mockersf
approved these changes
Mar 7, 2022
IceSentry
approved these changes
Mar 7, 2022
james7132
approved these changes
Mar 7, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# Objective Fixes #4133 ## Solution Add comparisons to make sure we don't dereference `Mut<>` in the two places where `Transform` is being mutated. `GlobalTransform` implementation already works properly so fixing Transform automatically fixed that as well.
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Fixes bevyengine#4133 ## Solution Add comparisons to make sure we don't dereference `Mut<>` in the two places where `Transform` is being mutated. `GlobalTransform` implementation already works properly so fixing Transform automatically fixed that as well.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#4133 ## Solution Add comparisons to make sure we don't dereference `Mut<>` in the two places where `Transform` is being mutated. `GlobalTransform` implementation already works properly so fixing Transform automatically fixed that as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4133
Solution
Add comparisons to make sure we don't dereference
Mut<>in the two places whereTransformis being mutated.GlobalTransformimplementation already works properly so fixing Transform automatically fixed that as well.