[Merged by Bors] - Fix mesh2d_manual example #4037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Rendering
| // This is the sum of the size of position and color attributes (12 + 16 = 28) | ||
| let vertex_array_stride = 28; | ||
|
|
||
| let vertex_layout = |
alice-i-cecile
approved these changes
Feb 25, 2022
|
I updated the description with slightly more info about the color situation. |
alice-i-cecile
added
the
P-Regression
|
@bevyengine/rendering-team, can I get a review from one of y'all? Then I'll be able to merge this in to fix the broken example :) |
superdump
requested changes
Feb 26, 2022
|
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# Objective - `Mesh::ATTRIBUTE_COLOR` expects colors as `u32`s but there is no function for easy conversion. - See #4037 (review) ## Solution - Added `Color::as_rgba_u32` and `Color::as_linear_rgba_u32`
rparrett
force-pushed
the
fix-mesh2d-manual
branch
from
5744410 to
3cccfd0
Compare
james7132
approved these changes
Mar 8, 2022
superdump
approved these changes
Mar 8, 2022
mockersf
reviewed
Mar 8, 2022
| @@ -243,7 +230,7 @@ fn vertex(vertex: Vertex) -> VertexOutput { | |||
| var out: VertexOutput; | |||
| // Project the world position of the mesh into screen position | |||
| out.clip_position = view.view_proj * mesh.model * vec4<f32>(vertex.position, 1.0); | |||
| out.color = vertex.color; | |||
| out.color = vec4<f32>((vec4<u32>(vertex.color) >> vec4<u32>(0u, 8u, 16u, 24u)) & vec4<u32>(255u)) / 255.0; | |||
There was a problem hiding this comment.
a comment explaining this line could be nice
There was a problem hiding this comment.
I'm not sure that I can adequately explain the process, but I added a comment that hopefully communicates the intent of the code.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# Objective Fixes #4036 ## Solution - Use `VertexBufferLayout::from_vertex_formats` - Actually put a u32 into `ATTRIBUTE_COLOR` and convert it in the shader I'm not 100% sure about the color stuff. It seems like `ATTRIBUTE_COLOR` has been `Uint32` this whole time, but this example previously worked with `[f32; 4]` somehow, perhaps because the vertex layout was manually specified. Let me know if that can be improved, or feel free to close for an alternative fix.
mockersf
approved these changes
Mar 8, 2022
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - `Mesh::ATTRIBUTE_COLOR` expects colors as `u32`s but there is no function for easy conversion. - See bevyengine#4037 (review) ## Solution - Added `Color::as_rgba_u32` and `Color::as_linear_rgba_u32`
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Fixes bevyengine#4036 ## Solution - Use `VertexBufferLayout::from_vertex_formats` - Actually put a u32 into `ATTRIBUTE_COLOR` and convert it in the shader I'm not 100% sure about the color stuff. It seems like `ATTRIBUTE_COLOR` has been `Uint32` this whole time, but this example previously worked with `[f32; 4]` somehow, perhaps because the vertex layout was manually specified. Let me know if that can be improved, or feel free to close for an alternative fix.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `Mesh::ATTRIBUTE_COLOR` expects colors as `u32`s but there is no function for easy conversion. - See bevyengine#4037 (review) ## Solution - Added `Color::as_rgba_u32` and `Color::as_linear_rgba_u32`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#4036 ## Solution - Use `VertexBufferLayout::from_vertex_formats` - Actually put a u32 into `ATTRIBUTE_COLOR` and convert it in the shader I'm not 100% sure about the color stuff. It seems like `ATTRIBUTE_COLOR` has been `Uint32` this whole time, but this example previously worked with `[f32; 4]` somehow, perhaps because the vertex layout was manually specified. Let me know if that can be improved, or feel free to close for an alternative fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4036
Solution
VertexBufferLayout::from_vertex_formatsATTRIBUTE_COLORand convert it in the shaderI'm not 100% sure about the color stuff. It seems like
ATTRIBUTE_COLORhas beenUint32this whole time, but this example previously worked with[f32; 4]somehow, perhaps because the vertex layout was manually specified.Let me know if that can be improved, or feel free to close for an alternative fix.