Remove child from parent when it is despawned #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleanCut
commented
Aug 29, 2020
| // the grandparent tuple (1, 1) and (0, 0) tuples remaining. | ||
| assert_eq!( | ||
| results, | ||
| vec![(0u32, 0u64), (0u32, 0u64), (0u32, 0u64), (1u32, 1u64)] |
There was a problem hiding this comment.
Question: Is the order of entities stable? If not, then we should probably alter the grandparent to also be (0u32, 0u64) to avoid a flaky test.
karroffel
added
C-Bug
memoryruins
reviewed
Sep 1, 2020
Co-authored-by: memoryruins <[email protected]>
cart
approved these changes
Sep 1, 2020
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
Remove child from parent when it is despawned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
despawn_with_children_recursivewas despawning an entity and all of its children, but did not remove itself as a child from its own parent.There is one question I would like answered. I will ask it in a comment on the line I am concerned about.
This is my first foray into the internals of bevy. I would appreciate any guidance on what I may have done wrong or could be done better. Please feel free to push commits directly to this branch if you have write permissions (I've enabled "allow edits by maintainers").
Resolves #352
/cc @ncallaway @cart