Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add more logs when despawning entities #3851

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - add more logs when despawning entities #3851

wants to merge 5 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 2, 2022

Objective

  • Provide more information when despawning an entity

Solution

  • Add a debug log when despawning an entity
  • Add spans to the recursive ways of despawning an entity
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...

DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 2, 2022
@mockersf mockersf mentioned this pull request Feb 3, 2022
Open
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-Log C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 3, 2022
@alice-i-cecile
Copy link
Member

RUST_LOG=debug cargo run --example panic --features trace
I'm nervous about this being very hard to discover, but I think it's the right approach.

@mockersf
Copy link
Member Author

mockersf commented Feb 3, 2022

I'm nervous about this being very hard to discover, but I think it's the right approach.

If the two PRs are merged, I'll update the error message for discovery, and add an error code, and ...
but I prefer small PR instead of all at once, so it'll wait 😄

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 13, 2022
@alice-i-cecile alice-i-cecile added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Apr 13, 2022
@mockersf mockersf removed the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Apr 13, 2022
@mockersf
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 13, 2022
@mockersf
add more logs when despawning entities (#3851)
8630b19 
# Objective

- Provide more information when despawning an entity

## Solution

- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity

```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...

DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
@bors
Copy link
Contributor

bors bot commented Apr 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add more logs when despawning entities [Merged by Bors] - add more logs when despawning entities Apr 13, 2022
@bors bors bot closed this Apr 13, 2022
infmagic2047
infmagic2047 reviewed Apr 14, 2022
View reviewed changes
crates/bevy_transform/Cargo.toml
@@ -8,6 +8,9 @@ repository = "https://github.com/bevyengine/bevy"
license = "MIT OR Apache-2.0"
keywords = ["bevy"]

[features]
trace = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, this must be some case of auto-merge failure. The feature should be on bevy_hierarchy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 #4477

mockersf added a commit to mockersf/bevy that referenced this pull request Apr 14, 2022
@mockersf
fix feature location from bevyengine#3851
fae5c9a
@mockersf mockersf mentioned this pull request Apr 14, 2022
Closed
bors bot pushed a commit that referenced this pull request Apr 14, 2022
@mockersf
fix feature location from #3851 (#4477)
d37cde8 
# Objective

- in #3851, a feature for tracing was added to bevy_transform
- usage of that feature was moved to bevy_hierarchy, but the feature was not updated

## Solution

- add the feature to bevy_hierarchy, remove it from bevy_transform
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
add more logs when despawning entities (bevyengine#3851)
161f9fa 
# Objective

- Provide more information when despawning an entity

## Solution

- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity

```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...

DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@mockersf @aevyrie
fix feature location from bevyengine#3851 (bevyengine#4477)
ab07397 
# Objective

- in bevyengine#3851, a feature for tracing was added to bevy_transform
- usage of that feature was moved to bevy_hierarchy, but the feature was not updated

## Solution

- add the feature to bevy_hierarchy, remove it from bevy_transform
@alice-i-cecile alice-i-cecile mentioned this pull request Jul 4, 2022
Closed
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
add more logs when despawning entities (bevyengine#3851)
6951c35 
# Objective

- Provide more information when despawning an entity

## Solution

- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity

```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...

DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
fix feature location from bevyengine#3851 (bevyengine#4477)
4eff1da 
# Objective

- in bevyengine#3851, a feature for tracing was added to bevy_transform
- usage of that feature was moved to bevy_hierarchy, but the feature was not updated

## Solution

- add the feature to bevy_hierarchy, remove it from bevy_transform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infmagic2047 infmagic2047 infmagic2047 left review comments

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @IceSentry @infmagic2047