Add Color::rgb_u8 and Color::rgba_u8 #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
added
C-Code-Quality
DJMcNab
reviewed
Aug 28, 2020
| @@ -37,6 +37,21 @@ impl Color { | |||
| pub const fn rgba(r: f32, g: f32, b: f32, a: f32) -> Color { | |||
There was a problem hiding this comment.
I think we could do with some doc comments on Color and its associated functions about being normalised values.
There was a problem hiding this comment.
Yeah i think that probably makes sense, both on the Color struct and on functions taking floats (rgba/rgb). Probably should be a separate PR though. Feel free to create one (or an issue to track it).
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to create colors from u8.
Resolve #364