[Merged by Bors] - Allow iter combinations on queries with filters #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harudagondi
force-pushed
the
allow-iter-combinations-on-queries-with-filters
branch
from
f832dee to
3f26e35
Compare
harudagondi
deleted the
allow-iter-combinations-on-queries-with-filters
branch
harudagondi
restored the
allow-iter-combinations-on-queries-with-filters
branch
MinerSebas
approved these changes
Jan 13, 2022
|
Okay, I honestly do not know how to remove commit 3f26e35 from there, since I am very much inexperienced with git and I don't know how it got there in the first place. Should I just make a new pull request instead, with the appropriate commits? Update: Just found out how to remove the commit using |
harudagondi
force-pushed
the
allow-iter-combinations-on-queries-with-filters
branch
from
93bd4d7 to
d6052f7
Compare
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Jan 13, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
DJMcNab
approved these changes
Jan 15, 2022
|
BTW @harudagondi, you can press "Resolve conversation" on the comments that have been addressed. It helps keep the thread clean for reviewers :) |
alice-i-cecile
approved these changes
Jan 16, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
# Objective - Previously, `iter_combinations()` does not work on queries that have filters. - Fixes #3651 ## Solution - Derived Copy on all `*Fetch<T>` structs, and manually implemented `Clone` to allow the test to pass (`.count()` does not work on `QueryCombinationIter` when `Clone` is derived) Co-authored-by: Carter Anderson <[email protected]>
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Previously, `iter_combinations()` does not work on queries that have filters. - Fixes bevyengine#3651 ## Solution - Derived Copy on all `*Fetch<T>` structs, and manually implemented `Clone` to allow the test to pass (`.count()` does not work on `QueryCombinationIter` when `Clone` is derived) Co-authored-by: Carter Anderson <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Previously, `iter_combinations()` does not work on queries that have filters. - Fixes bevyengine#3651 ## Solution - Derived Copy on all `*Fetch<T>` structs, and manually implemented `Clone` to allow the test to pass (`.count()` does not work on `QueryCombinationIter` when `Clone` is derived) Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
iter_combinations()does not work on queries that have filters.Solution
*Fetch<T>structs, and manually implementedCloneto allow the test to pass (.count()does not work onQueryCombinationIterwhenCloneis derived)