[Merged by Bors] - Use fully-qualified type names in proc macro. #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the code emitted by `derive_label` to use fully-qualified type names (e.g. `std::boxed::Box` instead of `Box`).
alice-i-cecile
approved these changes
Jan 4, 2022
alice-i-cecile
added
A-Core
C-Code-Quality
mockersf
approved these changes
Jan 4, 2022
|
Thanks for the review! bors r+ (It appears I misunderstood who is supposed to trigger Bors -- will wait for someone to get around to it) |
|
🔒 Permission denied Existing reviewers: click here to make mnett82 a reviewer |
Yep, this is currently scoped to @cart (full rights), @mockersf (trivial code quality improvements) and myself (docs!). In this case, this PR is in the second group, so @mockersf will likely be the one to merge this in. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
Modifies the code emitted by `derive_label` to use fully-qualified type names (e.g. `std::boxed::Box` instead of `Box`). # Objective - Using unqualified types here causes errors when the proc macro is used in contexts that locally define types with conflicting names (e.g. a local definition of `Box`). ## Solution - Fully qualify standard types emitted by the proc macro code.
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the code emitted by
derive_labelto use fully-qualified typenames (e.g.
std::boxed::Boxinstead ofBox).Objective
Box).Solution