Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix custom mesh pipelines #3381

Closed
wants to merge 3 commits into from

Conversation

Davier
Copy link
Contributor

@Davier Davier commented Dec 19, 2021

Objective

Fixes #3379

Solution

The custom mesh pipelines needed to be specialized on each mesh's primitive topology, as done in queue_meshes()

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 19, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Dec 19, 2021
@cart
Copy link
Member

cart commented Dec 20, 2021

Nice fix! Just pushed small tweaks that I think slightly improve legibility.

@cart
Copy link
Member

cart commented Dec 20, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2021
# Objective

Fixes #3379 

## Solution

The custom mesh pipelines needed to be specialized on each mesh's primitive topology, as done in `queue_meshes()`

Co-authored-by: Carter Anderson <[email protected]>
@bors bors bot changed the title Fix custom mesh pipelines [Merged by Bors] - Fix custom mesh pipelines Dec 20, 2021
@bors bors bot closed this Dec 20, 2021
@Davier Davier deleted the fix_custom_pipelines branch December 20, 2021 21:00
mockersf pushed a commit to mockersf/bevy that referenced this pull request Dec 21, 2021
# Objective

Fixes bevyengine#3379 

## Solution

The custom mesh pipelines needed to be specialized on each mesh's primitive topology, as done in `queue_meshes()`

Co-authored-by: Carter Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some examples do not work under the new renderer
3 participants