Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add an example 'showcasing' using multiple windows #3367

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add an example 'showcasing' using multiple windows #3367

wants to merge 1 commit into from
+118 −2

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Dec 17, 2021 •
edited
Loading

Objective

Solution

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 17, 2021
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled labels Dec 18, 2021
alice-i-cecile
alice-i-cecile approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice and simple, but very useful if you need it.

@cart
Copy link
Member

cart commented Dec 18, 2021

I had it in my head that we'd need some code changes to make this work. Glad to be proven wrong!

@cart
Copy link
Member

cart commented Dec 18, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 18, 2021
@DJMcNab
Add an example 'showcasing' using multiple windows (#3367)
ed9d45f 
# Objective

- The multiple windows example which was viciously murdered in #3175.
- cart asked me to

## Solution

- Rework the example to work on pipelined-rendering, based on the work from #2898
@bors
Copy link
Contributor

bors bot commented Dec 18, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add an example 'showcasing' using multiple windows [Merged by Bors] - Add an example 'showcasing' using multiple windows Dec 18, 2021
@bors bors bot closed this Dec 18, 2021
@DJMcNab DJMcNab deleted the frigidaria branch December 18, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DJMcNab @cart @alice-i-cecile