[Merged by Bors] - Expose command encoders #3271
Conversation
alice-i-cecile
added
A-Rendering
|
Maybe we should reexport
|
Its worth considering. But I do like having full control over our namespace. We already alias a number of wgpu types with our own (Texture, Buffer, RenderPiplineDescriptor, etc). Exporting wgpu wholesale makes talking about these types more difficult and introduces new (and possibly confusing and hard to debug) error cases for users of ide tooling like rust-analyzer. For now, I'd prefer to be selective here. If we miss something, users always have the escape hatch of pulling in wgpu directly. We should just do a thorough pass over the types wgpu exports and add everything we (I) missed. From there gaps should be few and far between. |
|
Definitely open to reconsidering how / where we export these types. |
|
bors r+ |
|
(merging because this is useful now ... feel free to keep discussing) |
# Objective I'm exposing these command encoders so bevy user's can create their own command encoders. This is useful when you want to copy a texture to a texture or create a compute pass manually for example. Note: I formatted this file which might of changed the order of some exports. ## Solution Just re-export `CommandEncoder` and `CommandEncoderDescriptor`.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Objective
I'm exposing these command encoders so bevy user's can create their own command encoders. This is useful when you want to copy a texture to a texture or create a compute pass manually for example.
Note: I formatted this file which might of changed the order of some exports.
Solution
Just re-export
CommandEncoderandCommandEncoderDescriptor.