[Merged by Bors] - default features from bevy_asset and bevy_ecs can actually be disabled
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
disable-default-features
branch
from
a69e3da to
1ab4e52
Compare
|
Hmm if we're going to disable filesystem_watcher in all dependencies, maybe we should just remove it as a default feature in |
alice-i-cecile
added
A-ECS
|
bors r+ |
|
Merge conflict. |
mockersf
force-pushed
the
disable-default-features
branch
from
291b2f6 to
e7ba138
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2021
…abled (#3097) # Objective - `bevy_ecs` exposes as an optional feature `bevy_reflect`. Disabling it doesn't compile. - `bevy_asset` exposes as an optional feature `filesystem_watcher`. Disabling it doesn't compile. It is also not possible to disable this feature from Bevy ## Solution - Fix compilation errors when disabling the default features. Make it possible to disable the feature `filesystem_watcher` from Bevy
bors
bot
changed the title
bevy_asset and bevy_ecs can actually be disabledbevy_asset and bevy_ecs can actually be disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ecsexposes as an optional featurebevy_reflect. Disabling it doesn't compile.bevy_assetexposes as an optional featurefilesystem_watcher. Disabling it doesn't compile. It is also not possible to disable this feature from BevySolution
filesystem_watcherfrom Bevy