Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update for edition 2021 #2997

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Update for edition 2021 #2997

wants to merge 6 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • update for Edition 2021

Solution

@alice-i-cecile alice-i-cecile added this to the Bevy 0.6 milestone Oct 21, 2021
@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Oct 21, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 21, 2021
@Ixentus
Copy link
Contributor

Ixentus commented Oct 21, 2021

Maybe add rust-version = "1.56" to close #2998 while you're at it :)

@Ixentus Ixentus mentioned this pull request Oct 21, 2021
Closed
@mockersf mockersf closed this Oct 21, 2021
@mockersf
Copy link
Member Author

mockersf commented Oct 21, 2021 •
edited
Loading

Maybe add rust-version = "1.56" to close #2998 while you're at it :)

I wouldn't want to do that without adding a CI to check that, and I'm not sure I want to add that CI yet...

@mockersf mockersf reopened this Oct 21, 2021
@alice-i-cecile
Copy link
Member

I wouldn't want to do that without adding a CI to check that, and I'm not sure I want to add that CI yet...

Unfortunately it looks like the rust-version field doesn't support "latest" 😂

I agree with that choice; I would prefer if we had some sort of CI to verify that those all get updated in sync.

@mockersf
Copy link
Member Author

CI failures are mostly because rust version in GitHub actions image has not yet been updated to 1.56

@Octorine Octorine mentioned this pull request Oct 23, 2021
Closed
@mockersf
Copy link
Member Author

checking if GitHub rust has been updated

bors try

bors bot added a commit that referenced this pull request Oct 25, 2021
@bors
Try #2997:
a4b6475
@bors
Copy link
Contributor

bors bot commented Oct 25, 2021

try

Build failed:

@mockersf mockersf mentioned this pull request Oct 25, 2021
Closed
@MinerSebas MinerSebas mentioned this pull request Oct 25, 2021
Closed
@cart
Copy link
Member

cart commented Oct 25, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 25, 2021
@mockersf
Update for edition 2021 (#2997)
2f4bcc5 
# Objective

- update for Edition 2021

## Solution

- remove the `resolver = "2"`
- update for https://doc.rust-lang.org/edition-guide/rust-2021/reserving-syntax.html by adding a few ` `
@bors
Copy link
Contributor

bors bot commented Oct 25, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title Update for edition 2021 [Merged by Bors] - Update for edition 2021 Oct 25, 2021
@bors bors bot closed this Oct 25, 2021
bors bot pushed a commit that referenced this pull request Nov 10, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
771c5f5 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
bors bot pushed a commit that referenced this pull request Nov 10, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
d98c2fe 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
bors bot pushed a commit that referenced this pull request Nov 11, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
36394ad 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
@JayPavlina JayPavlina mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobhellermann jakobhellermann jakobhellermann approved these changes

@NiklasEi NiklasEi NiklasEi approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.
6 participants
@mockersf @Ixentus @alice-i-cecile @cart @NiklasEi @jakobhellermann