Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Apply labels to wgpu resources for improved debugging/profiling #2912

Conversation

superdump
Copy link
Contributor

Objective

$subj. All of these names show up in external tools when debugging/profiling frames, which is super useful.

@cart
Copy link
Member

cart commented Oct 3, 2021

One downside worth discussing (but not particularly relevant to these changes): including the profiling string does include an extra allocation (because internally they convert the &str to a string). For anything "high frequency" we should consider not using labels. That being said, everything here seems fine.

@cart
Copy link
Member

cart commented Oct 3, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 3, 2021
# Objective

$subj. All of these names show up in external tools when debugging/profiling frames, which is super useful.
@bors
Copy link
Contributor

bors bot commented Oct 3, 2021

@bors bors bot changed the title Apply labels to wgpu resources for improved debugging/profiling [Merged by Bors] - Apply labels to wgpu resources for improved debugging/profiling Oct 3, 2021
@bors bors bot closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants