-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Expose wgpu's StencilOperation with bevy #2819
Closed
VVishion
wants to merge
1
commit into
bevyengine:pipelined-rendering
from
VVishion:expose-wgpu-type-stencil-operation
Closed
[Merged by Bors] - Expose wgpu's StencilOperation with bevy #2819
VVishion
wants to merge
1
commit into
bevyengine:pipelined-rendering
from
VVishion:expose-wgpu-type-stencil-operation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Objective Bevy should expose all wgpu types needed for building rendering pipelines. ## Solution Add wgpu's StencilOperation to bevy_render2::render_resource's export.
alice-i-cecile
added
A-Rendering
Drawing game state to the screen
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
labels
Sep 14, 2021
alice-i-cecile
approved these changes
Sep 14, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Sep 14, 2021
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
# Objective Bevy should expose all wgpu types needed for building rendering pipelines. Closes #2818 ## Solution Add wgpu's StencilOperation to bevy_render2::render_resource's export.
Timed out. |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
# Objective Bevy should expose all wgpu types needed for building rendering pipelines. Closes #2818 ## Solution Add wgpu's StencilOperation to bevy_render2::render_resource's export.
Build failed: |
network errors on crates.io bors retry |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
# Objective Bevy should expose all wgpu types needed for building rendering pipelines. Closes #2818 ## Solution Add wgpu's StencilOperation to bevy_render2::render_resource's export.
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Expose wgpu's StencilOperation with bevy
[Merged by Bors] - Expose wgpu's StencilOperation with bevy
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Rendering
Drawing game state to the screen
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Bevy should expose all wgpu types needed for building rendering pipelines.
Closes #2818
Solution
Add wgpu's StencilOperation to bevy_render2::render_resource's export.