[Merged by Bors] - Fix Option<NonSend<T>> and Option<NonSendMut<T>> #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e553e4e.
alice-i-cecile
added
A-ECS
|
The comment fixes look like this got pulled in from a different PR perhaps? They look good to merge, but it would be cleaner with just the two fix commits and the tests in there. |
yea thats true, fixed that. |
mockersf
approved these changes
Aug 31, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Aug 31, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 31, 2021
# Objective Fix `Option<NonSend<T>>` to work when T isn't `Send` Fix `Option<NonSendMut<T>>` to work when T isnt in the world. ## Solution Simple two row fix, properly initialize T in `OptionNonSendState` and remove `T: Component` bound for `Option<NonSendMut<T>>` also added a rudimentary test Co-authored-by: Ïvar Källström <[email protected]>
bors
bot
changed the title
bilsen
added a commit
to bilsen/bevy
that referenced
this pull request
Sep 2, 2021
# Objective Fix `Option<NonSend<T>>` to work when T isn't `Send` Fix `Option<NonSendMut<T>>` to work when T isnt in the world. ## Solution Simple two row fix, properly initialize T in `OptionNonSendState` and remove `T: Component` bound for `Option<NonSendMut<T>>` also added a rudimentary test Co-authored-by: Ïvar Källström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix
Option<NonSend<T>>to work when T isn'tSendFix
Option<NonSendMut<T>>to work when T isnt in the world.Solution
Simple two row fix, properly initialize T in
OptionNonSendStateand removeT: Componentbound forOption<NonSendMut<T>>also added a rudimentary test