Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Reduce visibility of various types and fields #2690

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Reduce visibility of various types and fields #2690

wants to merge 1 commit into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Aug 19, 2021

See the individual commits.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 19, 2021
@bjorn3 bjorn3 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Aug 19, 2021
DJMcNab
DJMcNab approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, although I might ask you not to include the resolve_unknown commit because of my pr which does something similar but keeps the method.

crates/bevy_ecs/src/entity/mod.rs Outdated Show resolved Hide resolved
@bjorn3
Reduce visibility of various types and fields
d092e81 
to match the visibility of the containing module or type
@bjorn3 bjorn3 force-pushed the ecs_improvements2 branch from 92a3fc6 to d092e81 Compare August 19, 2021 16:22
@bjorn3 bjorn3 changed the title Couple of small ecs cleanups Reduce visibility of various types and fields Aug 19, 2021
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 19, 2021
@cart
Copy link
Member

cart commented Aug 19, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 19, 2021
@bjorn3
Reduce visibility of various types and fields (#2690)
d84c7f9 
See the individual commits.
@bors
Copy link
Contributor

bors bot commented Aug 19, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Reduce visibility of various types and fields [Merged by Bors] - Reduce visibility of various types and fields Aug 19, 2021
@bors bors bot closed this Aug 19, 2021
@bjorn3 bjorn3 deleted the ecs_improvements2 branch August 19, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjorn3 @cart @mockersf @DJMcNab