Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove with bundle filter #2623

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Remove with bundle filter #2623

wants to merge 6 commits into from

Conversation

Hoidigan
Copy link
Contributor

@Hoidigan Hoidigan commented Aug 9, 2021

Objective

Fixes #2620

Solution

Remove WithBundle filter and temporarily remove example for query_bundle.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 9, 2021
mockersf
mockersf requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the example should be removed completely rather than commented out

@Hoidigan
Copy link
Contributor Author

Hoidigan commented Aug 9, 2021

It's not very happy I deleted the example :(
Is there something you have to do to get it to delete it beyond just deleting the file?

@mockersf
Copy link
Member

mockersf commented Aug 9, 2021

You also need to remove it:

bevy/Cargo.toml

Lines 321 to 323 in 90586a4

[[example]]
name = "query_bundle"
path = "examples/ecs/query_bundle.rs"

bevy/examples/README.md

Line 165 in 90586a4

`query_bundle` | [`ecs/query_bundle.rs`](./ecs/query_bundle.rs) | Shows how to query entities that contain components in a `Bundle`

@mockersf
Copy link
Member

mockersf commented Aug 9, 2021

unrelated ci failure

@Hoidigan
Copy link
Contributor Author

Hoidigan commented Aug 9, 2021

So is there anything I need to do for this? I'm still kinda confused as to what I do at this point, if anything.

@mockersf
Copy link
Member

mockersf commented Aug 9, 2021

nothing to do for now, you can wait for reviews/comments 🙂

@NiklasEi NiklasEi added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Aug 9, 2021
NiklasEi
NiklasEi suggested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@NiklasEi NiklasEi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter is mentioned in a doc comment l. 15 bevy_ecs/src/bundle.rs. Please remove that mention, too.

@cart
Copy link
Member

cart commented Aug 10, 2021

Looks good to me!

@cart
Copy link
Member

cart commented Aug 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 10, 2021
@Hoidigan
Remove with bundle filter (#2623)
49038d0 
# Objective

Fixes #2620

## Solution

Remove WithBundle filter and temporarily remove example for query_bundle.
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove with bundle filter [Merged by Bors] - Remove with bundle filter Aug 10, 2021
@bors bors bot closed this Aug 10, 2021
@Hoidigan Hoidigan deleted the remove-with-bundle-filter branch August 10, 2021 13:36
@MinerSebas MinerSebas mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi requested changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anti-feature request: remove WithBundle
4 participants
@Hoidigan @mockersf @cart @NiklasEi