[Merged by Bors] - Remove unnecessary exceptions for wgpu #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
added
A-Build-System
|
why do you think they are unnecessary? |
|
Should've clarified 😅 : they'll soon be unnecessary, as gfx-rs/wgpu#1516 will remove the need for it. |
TheRawMeatball
added
the
S-Blocked
|
Wgpu 0.9 has dropped with the new license! |
|
Could you also do the update to wgpu 0.9 in this PR? It would be best to remove exceptions and update in the same PR otherwise CI will be broken between the two |
|
to be done after #2371 |
TheRawMeatball
removed
the
S-Blocked
alice-i-cecile
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Looks like upstream got merged; we can merge this in now @mockersf.
alice-i-cecile
added
the
S-Ready-For-Final-Review
MinerSebas
approved these changes
Jun 24, 2021
DJMcNab
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
🎉
Just @Cupnfish for OptimisticPeach/hexasphere#7 remaining
|
They just responded. |
|
@TheRawMeatball could you resolve the conflicts ? |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.