[Merged by Bors] - Fix bad bounds for NonSend SystemParams #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRawMeatball
added
C-Bug
TheRawMeatball
approved these changes
Jun 9, 2021
|
As #2326 also fixes the wrong bound of |
MinerSebas
changed the title
|
Nice catch! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
# Objective Currently, you can't call `is_added` or `is_changed` on a `NonSend` SystemParam, unless the Resource is a Component (implements `Send` and `Sync`). This defeats the purpose of providing change detection for NonSend Resources. While fixing this, I also noticed that `NonSend` does not have a bound at all on its struct. ## Solution Change the bounds of `T` to always be `'static`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
# Objective Currently, you can't call `is_added` or `is_changed` on a `NonSend` SystemParam, unless the Resource is a Component (implements `Send` and `Sync`). This defeats the purpose of providing change detection for NonSend Resources. While fixing this, I also noticed that `NonSend` does not have a bound at all on its struct. ## Solution Change the bounds of `T` to always be `'static`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently, you can't call
is_addedoris_changedon aNonSendSystemParam, unless the Resource is a Component (implementsSendandSync).This defeats the purpose of providing change detection for NonSend Resources.
While fixing this, I also noticed that
NonSenddoes not have a bound at all on its struct.Solution
Change the bounds of
Tto always be'static.