-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add file metadata to AssetIo #2123
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
NathanSWard
reviewed
May 6, 2021
alice-i-cecile
added
A-Assets
Load files from disk to use for things like images, models, and sounds
C-Feature
A new feature, making something new possible
labels
May 6, 2021
mockersf
reviewed
May 7, 2021
NathanSWard
reviewed
May 7, 2021
mockersf
reviewed
May 9, 2021
mockersf
reviewed
May 9, 2021
mockersf
approved these changes
May 9, 2021
NathanSWard
reviewed
May 10, 2021
NathanSWard
reviewed
May 10, 2021
NathanSWard
approved these changes
May 13, 2021
bors try |
NathanSWard
reviewed
May 18, 2021
NathanSWard
reviewed
May 18, 2021
mockersf
reviewed
Jun 8, 2021
mockersf
added
S-Pre-Relicense
This PR was made before Bevy added the Apache license. Cannot be merged or used for other work
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
labels
Jul 16, 2021
geckoxx
force-pushed
the
file_metadata
branch
from
February 10, 2022 08:00
783c524
to
6b38170
Compare
IceSentry
approved these changes
Feb 10, 2022
mockersf
removed
the
S-Pre-Relicense
This PR was made before Bevy added the Apache license. Cannot be merged or used for other work
label
Apr 13, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 2, 2022
This is a replacement for #2106 This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type. It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext` I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
bors
bot
changed the title
Add file metadata to AssetIo
[Merged by Bors] - Add file metadata to AssetIo
May 2, 2022
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
This is a replacement for bevyengine#2106 This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type. It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext` I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
This is a replacement for bevyengine#2106 This adds a `Metadata` struct which contains metadata information about a file, at the moment only the file type. It also adds a `get_metadata` to `AssetIo` trait and an `asset_io` accessor method to `AssetServer` and `LoadContext` I am not sure about the changes in `AndroidAssetIo ` and `WasmAssetIo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Assets
Load files from disk to use for things like images, models, and sounds
C-Feature
A new feature, making something new possible
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #2106
This adds a
Metadata
struct which contains metadata information about a file, at the moment only the file type.It also adds a
get_metadata
toAssetIo
trait and anasset_io
accessor method toAssetServer
andLoadContext
I am not sure about the changes in
AndroidAssetIo
andWasmAssetIo
.