Replace glsl-to-spirv and spirv-reflect with Naga #209
Conversation
|
I love this. Naga is a big step forward in terms of build complexity and compile times. I'll try to review as soon as I can. |
lachlansneff
force-pushed
the
friendship-ended-with-spirv-reflect-now-naga-is-my-best-friend
branch
from
22e6ff1 to
9a1a498
Compare
|
I also just added a preprocessor in the |
lachlansneff
force-pushed
the
friendship-ended-with-spirv-reflect-now-naga-is-my-best-friend
branch
from
a47749c to
1355128
Compare
|
FYI I just tried rebasing this onto the current master commit, applied the fixes I've been experimenting with for wasm for the non-rendering-related stuff, and managed to compile all crates to wasm! No idea yet if rendering will actually work on the web, but the tests still pass and examples still run on Linux, and without this PR I couldn't get anything depending on the renderer to compile to wasm at all. |
karroffel
added
A-Build-System
There was a problem hiding this comment.
@lachlansneff Great job! I'm just going to give it a chance in webgl2_renderer backend. Could you rebase it on current master? Do you have an idea will it work with "300 es" shaders? Thanks!
EDIT:
I played a bit with this PR and bevy's 2d sprite and sprite_sheet examples. First I've rebased it on current master and changed naga to latest version (some minor changes were required: mrk-its@14ada61). Then I was able to compile sprite example. Unfortunately it panics a lot:
- vertex sprite shader was parsed, but it failed while writing spirv data.
- after disabling conversion to spirv it failed on parsing fragment shader.
| (Float, 4) => VertexFormat::Float, | ||
| _ => return Err(()), | ||
| }, | ||
| Vector { size, kind, width } => match (size, kind, width) { |
There was a problem hiding this comment.
It would be great to have this (size, kind, width) information preserved. Take a look on my webgl2_renderer: https://github.com/bevyengine/bevy/pull/613/files#diff-d4ccfb870bfebbfae7f1b458a69aed63 - I have to recreate this information from this enum :)
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
removed
the
S-Ready-For-Final-Review
|
I tried updating this PR to current bevy main and released |
|
Dang. Thanks for checking. Hopefully we'll be able to use it Soon™ 😄 |
Replace both
bevy-glsl-to-spirv(a fork ofglsl-to-spirv) andspirv-reflectwithnagaThis should reduce compile times a lot, as well make it easier to cross-compile for platforms like android, ios, and webassembly.
The glsl frontends and spirv backend for
nagaare not very mature yet. They're progressing pretty quickly, but they're still not usable for real applications yet. Hopefully this will change in the upcoming weeks.