[Merged by Bors] - Automatic System Spans #2033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
A-ECS
NathanSWard
reviewed
Apr 27, 2021
NathanSWard
reviewed
Apr 27, 2021
Comment on lines
49
to
57
| #[cfg(feature = "trace")] | ||
| let trace_path = Some(std::path::Path::new("wgpu_trace")); | ||
| let trace_path = { | ||
| let path = std::path::Path::new("wgpu_trace"); | ||
| // ignore potential error, wgpu will log it | ||
| let _ = std::fs::create_dir(path); | ||
| Some(path) | ||
| }; | ||
| #[cfg(not(feature = "trace"))] | ||
| let trace_path = None; |
There was a problem hiding this comment.
This whole block could be cobined into a if cfg!(...) expression which would be clearer imo.
let trace_path = if cfg!(feature = "trace") {
let path = std::path::Path::new("wgpu_trace");
// ignore potential error, wgpu will log it
let _ = std::fs::create_dir(path);
Some(path)
} else {
None
};There was a problem hiding this comment.
I prefer the current way as I feel it's less work for the compiler.
But then this should be very simple to compile away... 🤷
|
Just wanted to voice my appreciation for how often you quickly pick up and implement work that "needs to be done" (and its generally exactly what we need). You've done a lot to improve the quality of Bevy in a ton of different areas and its awesome to see. |
TehPers
reviewed
Apr 28, 2021
Co-Authored-By: TehPers <[email protected]>
|
Awesome. Chrome tracing now shows systems again! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
As mentioned in #2025 (comment), systems used to have spans by default. * add spans by default for every system executed * create folder if missing for feature `wgpu_trace`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
NiklasEi
pushed a commit
to NiklasEi/bevy
that referenced
this pull request
May 1, 2021
As mentioned in bevyengine#2025 (comment), systems used to have spans by default. * add spans by default for every system executed * create folder if missing for feature `wgpu_trace`
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
As mentioned in bevyengine#2025 (comment), systems used to have spans by default. * add spans by default for every system executed * create folder if missing for feature `wgpu_trace`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2025 (comment), systems used to have spans by default.
wgpu_trace