Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - -Csplit-debuginfo=unpacked is default on nightly #1913

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - -Csplit-debuginfo=unpacked is default on nightly #1913

wants to merge 1 commit into from

Conversation

gfreezy
Copy link
Contributor

@gfreezy gfreezy commented Apr 13, 2021

@mockersf mockersf added A-Build-System Related to build systems or continuous integration O-MacOS Specific to the MacOS (Apple) desktop operating system labels Apr 13, 2021
@gfreezy
Copy link
Contributor Author

gfreezy commented Apr 13, 2021

Ci reports markdown lint errors in README and CHANGELOG. Should i fix it?
image

@bjorn3
Copy link
Contributor

bjorn3 commented Apr 13, 2021

#1096 will fix it.

@DJMcNab
Copy link
Member

DJMcNab commented Apr 13, 2021

Yeah, the issue is fixed by #1906, so this would be safe to merge (because bors checks the version from after rebase), although if you do come back to the code then rebasing would also make CI pass here

DJMcNab
DJMcNab approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already use a -Z flag, so it being set as default only on nightly is fine.

@DJMcNab DJMcNab added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 13, 2021
@bors
Copy link
Contributor

bors bot commented Apr 14, 2021

🔒 Permission denied

Existing reviewers: click here to make gfreezy a reviewer

DJMcNab
DJMcNab approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rebased code is the same change as I previously approved.

In future, if you're going to experiment with the bors commands, I'd advise you not to delete the comments, and instead perhaps edit them to explain why you tried that. In this repository, no-one other than @cart has bors permissions at the moment, and so running the commands will fail.

@gfreezy
Copy link
Contributor Author

gfreezy commented Apr 14, 2021

@DJMcNab I don’t know how to get the pr merged. After glancing other merged prs, I thought running bors commands might be needed.

@cart
Copy link
Member

cart commented Apr 15, 2021

Yup thats a reasonable guess. For now I'm the only one that can merge prs with bors r+

@cart
Copy link
Member

cart commented Apr 15, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 15, 2021
@gfreezy
-Csplit-debuginfo=unpacked is default on nightly (#1913)
92e543d 
rust-lang/cargo#9298
@bors
Copy link
Contributor

bors bot commented Apr 15, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title -Csplit-debuginfo=unpacked is default on nightly [Merged by Bors] - -Csplit-debuginfo=unpacked is default on nightly Apr 15, 2021
@bors bors bot closed this Apr 15, 2021
@bjorn3 bjorn3 mentioned this pull request Apr 18, 2021
Closed
@DJMcNab
Copy link
Member

DJMcNab commented Jul 6, 2021

@gfreezy please respond in #2373 for the relicense to MIT/Apache 2.0. Thanks!

ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@gfreezy @ostwilkens
-Csplit-debuginfo=unpacked is default on nightly (bevyengine#1913)
fcff440 
rust-lang/cargo#9298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration O-MacOS Specific to the MacOS (Apple) desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gfreezy @bjorn3 @DJMcNab @cart @mockersf