Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix SytemParam handling of Commands #1899

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix SytemParam handling of Commands #1899

wants to merge 1 commit into from

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Apr 12, 2021

Fixes #1896

@DJMcNab DJMcNab added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Apr 12, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 12, 2021
@cart
Copy link
Member

cart commented Apr 14, 2021

Ahh that explains it. Nice catch.

@cart
Copy link
Member

cart commented Apr 14, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2021
@DJMcNab
Fix SytemParam handling of Commands (#1899)
a137df7 
Fixes #1896
@bors
Copy link
Contributor

bors bot commented Apr 15, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix SytemParam handling of Commands [Merged by Bors] - Fix SytemParam handling of Commands Apr 15, 2021
@bors bors bot closed this Apr 15, 2021
@DJMcNab DJMcNab deleted the systemparam-commands branch April 15, 2021 06:02
@TheRawMeatball TheRawMeatball mentioned this pull request May 17, 2021
Closed
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@DJMcNab @ostwilkens
Fix SytemParam handling of Commands (bevyengine#1899)
ffaeab0 
Fixes bevyengine#1896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commands can't insert components to spawned entities if injected via a SystemParam
3 participants
@DJMcNab @cart @alice-i-cecile