-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Volume and GlobalVolume to own file #16838
Conversation
93ef1ec
to
39ac5b2
Compare
39ac5b2
to
1e39675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put a pin on improving the documentation of the Volume
newtype, because it's unclear from the doc comments which scale we are using (linear can be inferred from the debug_assert!
, but it would be nice to make it explicit).
Additionally, we should add a second constructor for setting the volume in decibels.
Absolutely. We can look at these in a follow up PR since this PR is just a simple move around. FWIW, I also noticed this from a user perspective. The constructor just says |
Objective
VolumeLevel
to use Decibel and Amplitude Ratio Units #9582.Solution
#[reflect(Debug)]
onVolume
while I'm here.Testing