Observed entity query data fetching: Trigger<FooEvent, (), (&mut Foo, &Bar)>
#15698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
commented
Oct 7, 2024
| // SAFETY: Delegate to other `System` implementations. | ||
| unsafe { self.a.validate_param_unsafe(world) && self.b.validate_param_unsafe(world) } | ||
| unsafe { | ||
| // TODO |
There was a problem hiding this comment.
TODO. Unsure how to handle validating the second system.
ItsDoot
commented
Oct 7, 2024
| fn validate_param(&mut self, world: &World) -> bool { | ||
| self.a.validate_param(world) && self.b.validate_param(world) | ||
| fn validate_param(&mut self, input: &SystemIn<'_, Self>, world: &World) -> bool { | ||
| // TODO |
There was a problem hiding this comment.
TODO. Unsure how to handle validating the second system.
SkiFire13
reviewed
Oct 7, 2024
| @@ -88,7 +88,7 @@ use super::{IntoSystem, ReadOnlySystem, System}; | |||
| label = "invalid system combination", | |||
| note = "the inputs and outputs of `{A}` and `{B}` are not compatible with this combiner" | |||
| )] | |||
| pub trait Combine<A: System, B: System> { | |||
| pub trait Combine<A: System<In = Self::In>, B: System<In = Self::In>> { | |||
There was a problem hiding this comment.
Isn't this a breaking change? It will force the two systems to have the same input type, so e.g. piping would no longer be implementable this way (not that bevy's implementation used Combine).
alice-i-cecile
added
C-Feature
|
Appears to implement #15653. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Adds a new type parameter
D: QueryDatatoTrigger<E, B, D>.Testing
Showcase
While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases:
Click to view showcase
Migration Guide