-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit execution order ambiguities API #1469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this: it will help us prepare for 0.5 by cleaning up the default system ambiguities, and we'll still need this tool once we have archetype invariants.
Are you planning to integrate this with #1423 or just leave these as stringly-typed until we get #1375? I can see either option being defensible.
Yes, definitely - it's easy enough to warrant doing this even for a "temporary" solution. This could be left out of #1423, for expediency, I'll just do a follow-up PR when it lands. Or it lands before this and I'll rebase 🤷♂️ |
I think this is good to go (once we resolve the one open thread) |
Ah, dang, rustfmt snuck in an unrelated change. It should be fine, just annoying. |
Explicit execution order ambiguities API.
This API allows marking systems as exempt from ambiguity detection with other systems with the same mark. E.g., this will not report any ambiguities:
It's a stopgap solution until some form of #1375 is implemented.