Fix error in bevy_ui
when building without bevy_text
#14430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_ui
does not build without thebevy_text
feature due to improper feature gating.MeasureArgs<'a>
had an unused lifetime'a
withoutbevy_text
enabled. This is because it stores a reference to acosmic_text::FontSystem
.flag-frenzy
in this run.Solution
PhantomData
toMeasureArgs<'a>
in order to maintain its lifetime argument.font_system
, after the feature-gated argument that actually needs a lifetime, for usability. Please comment if you have a better solution!bevy_text
feature gate.Testing
Migration Guide
This is not a breaking change for users migrating from 0.14, since
MeasureArgs
did not exist then.When the
bevy_text
feature is disabled forbevy_ui
, the type of theMeasureArgs::font_system
field is now aPhantomData
instead of being removed entirely. This is in order to keep the lifetime parameter, even though it is unused without text being enabled.