Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal Bubbling Observers #13991
Minimal Bubbling Observers #13991
Changes from 1 commit
1f59ecd
bab9f67
98ff396
faf63cb
4c4fc74
0b93ca2
bde5ff0
0225a42
a781188
595f621
f5a6a99
76530d5
902ec1e
3c02e79
d89c61c
33d2820
f7239bb
932630d
116b92d
e29fd6e
a6b4499
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 81 in crates/bevy_ecs/src/observer/mod.rs
GitHub Actions / typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it will be highly likely that traversals will be along "relations at home" components. With hooks people can now ensure that these graphs never become invalid. However to do so underlying
Component
types have to be private otherwise you can break invariants by doing this:I already do this in aery and hierarchy will have to do this when it starts using hooks so rather than being
Component
this should beQueryData
andnext
should take the item instead of self. You can just removeTraversalNone
and make the default query()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh actually this change might require #13375 first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I tried to design it this way originally and couldn't get the ref safety right, then designed a "minimal" version to use a single component. This would be best addressed as early follow-up, but I totally want this.