Adding push constants support #1369
Conversation
|
Blocked on #1401 |
alice-i-cecile
added
A-Rendering
Neo-Zhixing
force-pushed
the
push_constants
branch
from
d2c95bc to
53d979f
Compare
|
I think this would benefit from a minimal example that proves the feature works / illustrates how to use it. |
|
@cart This API isn't exactly user-facing, so I don't think it's a good idea to make a new example inside bevy. This PR is supposed to be the foundations for #1372, and we'd probably need to build a Please take a look at the following for an example of how this would work: |
|
Push constants would be user-facing in the sense that users could use them (like you are using them in the linked |
# Conflicts: # crates/bevy_render/src/pipeline/pipeline_layout.rs # crates/bevy_wgpu/src/wgpu_type_converter.rs
Neo-Zhixing
force-pushed
the
push_constants
branch
from
074cb8c to
8834821
Compare
|
This can probably be closed with the rendering rework right? It'll be very stale, and seems like we should wait for a compelling use case. |
mockersf
removed
the
S-Ready-For-Final-Review
|
The rework directly exposes the ability to enable push constants via gpu (because it uses wgpu directly), so I do think we can close this out. |
|
It doesn't look like |
This PR adds Push Constants support to the bevy rendering engine. This exposes the wgpu push constants API to the user.
However, we might want to coordinate with #547. Push Constants requires enabling the push constant feature and setting an appropriate resource limit. Therefore we might need to wait for #547, or maybe get this merged without enabling the push constants feature by default.