Fix panic in bevy_ui layout #12838
Closed
Fix panic in bevy_ui layout #12838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvbg
force-pushed
the
bevy_ui_layout_panic
branch
from
50117b9 to
63d8d17
Compare
msvbg
added
C-Bug
|
Alternatively, this is also addressed by #12805. (https://github.com/bevyengine/bevy/pull/12805/files#diff-91216818db3c390603f5a93d8a47d11e1a627d0c29578843800ea88849230b0cR296-R301) |
pablo-lua
approved these changes
Apr 1, 2024
|
Closing in favor of #12805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I encountered a panic in bevy_ui on this line, which calls
unwrap. It happened while I was despawning UI nodes, but I only saw it once and have been unable to reproduce it.Related to #12660.
Solution
Remove
unwrapand replace withlet ... elseand a warning.