Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic PBR #1160

Closed
wants to merge 6 commits into from
Closed

Basic PBR #1160

wants to merge 6 commits into from

Conversation

IngmarBitter
Copy link
Contributor

@IngmarBitter IngmarBitter commented Dec 28, 2020

Continuation of PR #261 as stated there:
This is a WIP draft PR for adding basic PBR (Physically Based Rendering) support to bevy. It uses this as a resource for this implementation:
https://google.github.io/filament/Filament.md.html

More changes.

Removed unused vars.

fixed warnings

The above is all work done by StarArawn that I combined to make rebasing easier
@Moxinilian Moxinilian added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Jan 1, 2021
@cart
Copy link
Member

cart commented Jan 3, 2021

Its a bit more work, but I'd appreciate it if you created a new branch from @StarArawn's branch and rebased those commits on master. That way @StarArawn gets properly attributed for their work.

Base automatically changed from master to main February 19, 2021 20:44
@mtsr
Copy link
Contributor

mtsr commented Mar 4, 2021

Currently working on cherry-picking these commits on top of StarArawns branch. PR incoming when it's done.

@cart
Copy link
Member

cart commented Mar 6, 2021

closing in favor of #1554

@cart cart closed this Mar 6, 2021
bors bot pushed a commit that referenced this pull request Mar 20, 2021
This is a rebase of StarArawns PBR work from #261 with IngmarBitters work from #1160 cherry-picked on top.

I had to make a few minor changes to make some intermediate commits compile and the end result is not yet 100% what I expected, so there's a bit more work to do.

Co-authored-by: John Mitchell <[email protected]>
Co-authored-by: Ingmar Bitter <[email protected]>
@DJMcNab
Copy link
Member

DJMcNab commented Jul 18, 2021

@IngmarBitter please see and comment in #2373 for the relicense to MIT/Apache 2.0

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants