-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make more information available from loaded GLTF model #1020
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
791d907
make gltf nodes available as assets
mockersf 0867828
add list of primitive per mesh, and their associated material
mockersf a470964
complete gltf structure
mockersf cc30ad2
get names of gltf assets
mockersf 6da061c
only load materials once
mockersf df4ef7e
format
mockersf 9a915c0
add labels with node names
mockersf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,60 @@ | ||
use std::collections::HashMap; | ||
|
||
mod loader; | ||
pub use loader::*; | ||
|
||
use bevy_app::prelude::*; | ||
use bevy_asset::AddAsset; | ||
use bevy_asset::{AddAsset, Handle}; | ||
use bevy_pbr::prelude::StandardMaterial; | ||
use bevy_reflect::TypeUuid; | ||
use bevy_render::mesh::Mesh; | ||
use bevy_scene::Scene; | ||
|
||
/// Adds support for GLTF file loading to Apps | ||
#[derive(Default)] | ||
pub struct GltfPlugin; | ||
|
||
impl Plugin for GltfPlugin { | ||
fn build(&self, app: &mut AppBuilder) { | ||
app.init_asset_loader::<GltfLoader>(); | ||
app.init_asset_loader::<GltfLoader>() | ||
.add_asset::<Gltf>() | ||
.add_asset::<GltfNode>() | ||
.add_asset::<GltfPrimitive>() | ||
.add_asset::<GltfMesh>(); | ||
} | ||
} | ||
|
||
#[derive(Debug, TypeUuid)] | ||
#[uuid = "5c7d5f8a-f7b0-4e45-a09e-406c0372fea2"] | ||
pub struct Gltf { | ||
pub scenes: Vec<Handle<Scene>>, | ||
pub named_scenes: HashMap<String, Handle<Scene>>, | ||
pub meshes: Vec<Handle<GltfMesh>>, | ||
pub named_meshes: HashMap<String, Handle<GltfMesh>>, | ||
pub materials: Vec<Handle<StandardMaterial>>, | ||
pub named_materials: HashMap<String, Handle<StandardMaterial>>, | ||
pub nodes: Vec<Handle<GltfNode>>, | ||
pub named_nodes: HashMap<String, Handle<GltfNode>>, | ||
pub default_scene: Option<Handle<Scene>>, | ||
} | ||
|
||
#[derive(Debug, Clone, TypeUuid)] | ||
#[uuid = "dad74750-1fd6-460f-ac51-0a7937563865"] | ||
pub struct GltfNode { | ||
pub children: Vec<GltfNode>, | ||
pub mesh: Option<Handle<GltfMesh>>, | ||
pub transform: bevy_transform::prelude::Transform, | ||
} | ||
|
||
#[derive(Debug, Clone, TypeUuid)] | ||
#[uuid = "8ceaec9a-926a-4f29-8ee3-578a69f42315"] | ||
pub struct GltfMesh { | ||
pub primitives: Vec<GltfPrimitive>, | ||
} | ||
|
||
#[derive(Debug, Clone, TypeUuid)] | ||
#[uuid = "cbfca302-82fd-41cb-af77-cab6b3d50af1"] | ||
pub struct GltfPrimitive { | ||
pub mesh: Handle<Mesh>, | ||
pub material: Option<Handle<StandardMaterial>>, | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes this kind of code fail compilation:
Is there a way to not be bothered with specifying the
T
parameter?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah that is suboptimal. Its both less ergonomic and creates a class of bug where the user specifies the wrong asset type.
We could make it
LoadedAsset<T>
, then created a BoxedLoadedAsset that we coerce it into withinset_labeled_asset