-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused CountdownEvent
#4287
Comments
My usual stance to something never used in Bevy is "remove it, see if someone complains on the PR"... In this case, this is very hard to discover, not obvious how to use, no example, and never came up on discord so... 🗑️ |
The usage is pretty simple, its a stripped down async barrier primitive, where counting and awaiting is separated. Not sure where I'd use it though. |
it's "pretty simple" but it's unlike anything else in Bevy. And I wouldn't call anything using async in rust "pretty simple" to be fair... |
This sync primitive is equivalent to the one discussed in this GDC talk, see at 16:50 for an example: https://www.gdcvault.com/play/1022186/Parallelizing-the-Naughty-Dog-Engine It is broadly useful for scatter/gather workloads which are typical in games. I think the most common case of wanting this would be to jobify existing code where, for whatever reason, the more rigid but safer callback-based approach of |
Thanks for the explanation. It sounds like this could definitely be useful, but if so it deserves proper docs demonstrating usage and tradeoffs, likely in the form of a complete example. |
# Objective Fixes: #4287 ## Solution I removed it.
# Objective Fixes: #4287 ## Solution I removed it.
# Objective Fixes: bevyengine#4287 ## Solution I removed it.
# Objective Fixes: bevyengine#4287 ## Solution I removed it.
How can Bevy's documentation be improved?
definition
re-export
Searching through source revealed that
CountdownEvent
is only used in it's definition file and in the module's re-export.Should it be kept or deleted?
The text was updated successfully, but these errors were encountered: