Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load GLTF files as scenes instead of meshes #33

Closed
cart opened this issue Jun 19, 2020 · 2 comments
Closed

Load GLTF files as scenes instead of meshes #33

cart opened this issue Jun 19, 2020 · 2 comments
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible

Comments

@cart
Copy link
Member

cart commented Jun 19, 2020

Now that the scene system is in place, it makes sense to load as much as possible from gltf files ... not just meshes.
@karroffel karroffel added A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible labels Aug 12, 2020
@voxelias
Copy link
Contributor

What is scene system?

@cart
Copy link
Member Author

cart commented Oct 30, 2020

Closed by #693

@cart cart closed this as completed Oct 30, 2020
robtfm pushed a commit to robtfm/bevy that referenced this issue Sep 16, 2023
@superdump
Merge pull request bevyengine#33 from robtfm/batching
a9e3585 
batching
tychedelia pushed a commit to tychedelia/bevy that referenced this issue Nov 23, 2024
@robtfm @VitalyAnkh
migrate to naga 0.13 (bevyengine#40)
1854567 
fixes bevyengine#33

this should not merged until bevy 0.11.1 is out. builds on @VitalyAnkh's
partial migration, with additionally :

- use `Rc<RefCell>` for `const_expressions` and `const_expr_map` - this
is basically unavoidable, as `DerivedModule::import_expression` needs
access to both the `const_expressions` and the arena to import into,
which may also be `const_expressions`
- don't emit `Expression::Literal` and `Expression::ZeroValue`s
- enforce `const_expression` uniqueness with a custom impl of
`PartialEq` for `Expression`s, to ensure that the uniqueness test for
globals and consts still passes (else we end up with duplicated items,
they no longer test as equal as they refer to different `init`
expressions). this could be removed if the `PartialEq` derive on
`Expression` in naga is made externally available.
- a basic port of the `prune` module which just leaves all
`const_expressions` present

the tests pass, but i haven't tried integrating into bevy (which will
require bevy to use wgpu 0.17).

---------

Co-authored-by: VitalyR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cart @voxelias @karroffel